COCOS-145 : Support Other Private/Public Key Pair Algorithms #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SammyOina
requested changes
Jun 14, 2024
|
update |
2 similar comments
|
update |
|
update |
SammyOina
requested changes
Jun 19, 2024
SammyOina
requested changes
Jun 19, 2024
SammyOina
reviewed
Jun 19, 2024
SammyOina
requested changes
Jun 24, 2024
There was a problem hiding this comment.
also signature verification fails for rsa keys generated by openssl
go run ./test/computations/main.go ./test/manual/data/iris.csv ./test/manual/algo/lin_reg.py ../rsa_public.key falseAGENT_GRPC_URL=localhost:35335 go run cmd/cli/main.go algo ./test/manual/algo/lin_reg.py ../rsa_private.key
2024/06/24 15:13:25 Uploading algorithm binary: ./test/manual/algo/lin_reg.py
2024/06/24 15:13:25 Error uploading algorithm with error: rpc error: code = Unauthenticated desc = signature verification failed
WashingtonKK
force-pushed
the
cocos-145
branch
2 times, most recently
from
7e8aea3 to
8f9ed97
Compare
Signed-off-by: WashingtonKK <[email protected]> pass cert to agent Signed-off-by: WashingtonKK <[email protected]> fix ci Signed-off-by: WashingtonKK <[email protected]> standardize key types Signed-off-by: WashingtonKK <[email protected]> marshal public key Signed-off-by: WashingtonKK <[email protected]> use openssl format for keys Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]> update makefile Signed-off-by: WashingtonKK <[email protected]> update agent Signed-off-by: WashingtonKK <[email protected]> enhance parsing logic Signed-off-by: WashingtonKK <[email protected]>
Signed-off-by: WashingtonKK <[email protected]> fix ci Signed-off-by: WashingtonKK <[email protected]> return key on successful signature verification Signed-off-by: WashingtonKK <[email protected]> fix cli Signed-off-by: WashingtonKK <[email protected]> fix ed25519 signing Signed-off-by: WashingtonKK <[email protected]> ci Signed-off-by: WashingtonKK <[email protected]>
SammyOina
requested changes
Jul 3, 2024
Signed-off-by: WashingtonKK <[email protected]>
SammyOina
reviewed
Jul 3, 2024
Signed-off-by: WashingtonKK <[email protected]>
SammyOina
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds support for other Public/Private key pair types.
What does this do?
This adds the following private/public key pair types in addition to the already existing RSA:
The PR allows generation of these keys, and modifies sdk to accept multiple key types to be used as digital signatures for agent.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No