Member type container in management API #16914
Merged
CodeScene Delta Analysis / CodeScene Code Health Review (v17/dev)
failed
Oct 1, 2025 in 45s
CodeScene PR Check
Quality Gate Failed
Gates Failed
(2 files with Constructor Over-Injection, Large Method)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| MemberTypeContainerService.cs | 1 advisory rule | 10.00 → 9.69 | Suppress |
| UmbracoBuilder.cs | 1 advisory rule | 8.62 → 8.61 | Suppress |
Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.
Details
🚩 Declining Code Health (highest to lowest):
- Large Method UmbracoBuilder.cs: AddCoreServices
- Constructor Over-Injection MemberTypeContainerService.cs: MemberTypeContainerService
Annotations
Check warning on line 22 in src/Umbraco.Core/Services/MemberTypeContainerService.cs
codescene-delta-analysis / CodeScene Code Health Review (v17/dev)
❌ New issue: Constructor Over-Injection
MemberTypeContainerService has 7 arguments, max arguments = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 332 in src/Umbraco.Core/DependencyInjection/UmbracoBuilder.cs
codescene-delta-analysis / CodeScene Code Health Review (v17/dev)
❌ Getting worse: Large Method
AddCoreServices increases from 207 to 208 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading