Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix#17149 User Validation on Audit Repository .Save Method #17248

Open
wants to merge 6 commits into
base: contrib
Choose a base branch
from

Conversation

IbrahimMNada
Copy link
Contributor

@IbrahimMNada IbrahimMNada commented Oct 11, 2024

Description

If there's an existing issue for this PR then this fixes #17149

this pull request is a fix for this issue : #17149

Which states that a content publish can be established using ContentService with a non existing user.

A Simple Database Validation/ and simple caching mechanism were added in order to check if the user really exists in the database

Copy link

github-actions bot commented Oct 11, 2024

Hi there @IbrahimMNada, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@JasonElkin
Copy link
Contributor

Hey @IbrahimMNada, thanks for making a PR to fix this 🎉

Someone from the team will get this reviewed and get back to you soon.

@IbrahimMNada
Copy link
Contributor Author

Any update on this
😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can publish content as non-existing user
3 participants