-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix#17149 User Validation on Audit Repository .Save Method #17248
base: contrib
Are you sure you want to change the base?
Conversation
Hi there @IbrahimMNada, thank you for this contribution! 👍 While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:
Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution. If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @IbrahimMNada, thanks for making a PR to fix this 🎉 Someone from the team will get this reviewed and get back to you soon. |
Any update on this |
Description
If there's an existing issue for this PR then this fixes #17149
this pull request is a fix for this issue : #17149
Which states that a content publish can be established using
ContentService
with a non existing user.A Simple Database Validation/ and simple caching mechanism were added in order to check if the user really exists in the database