Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update terminology in ListView acceptance tests for v14+. #17265

Open
wants to merge 1 commit into
base: contrib
Choose a base branch
from

Update terminology in ListView acceptance tests.

eb7f3ff
Select commit
Loading
Failed to load commit list.
Open

Update terminology in ListView acceptance tests for v14+. #17265

Update terminology in ListView acceptance tests.
eb7f3ff
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (contrib) succeeded Oct 13, 2024 in 31s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: +0.00 (9.39 -> 9.39)

  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Code Duplication ListView.spec.ts

Annotations

Check notice on line 246 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

ℹ Getting worse: Code Duplication 

introduced similar code in: 'can enable show Content Workspace View first','can update workspace view name'. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check notice on line 1 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/DataType/ListView.spec.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (contrib)

✅ Getting better: Code Duplication 

reduced similar code in: 'can enable show content app first','can update content app name'. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
View more details on CodeScene Delta Analysis