Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ public RootMemberTypeTreeController(IEntityService entityService, FlagProviderCo
public async Task<ActionResult<PagedViewModel<MemberTypeTreeItemResponseModel>>> Root(
CancellationToken cancellationToken,
int skip = 0,
int take = 100)
int take = 100,
bool foldersOnly = false)
=> await GetRoot(skip, take);
}
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Http;
using Microsoft.AspNetCore.Mvc;
using Umbraco.Cms.Api.Common.ViewModels.Pagination;
using Umbraco.Cms.Api.Management.Services.Flags;
Expand All @@ -23,6 +23,7 @@
CancellationToken cancellationToken,
Guid target,
int before,
int after)
int after,
bool foldersOnly = false)

Check warning on line 27 in src/Umbraco.Cms.Api.Management/Controllers/MemberType/Tree/SiblingMemberTypeTreeController.cs

View check run for this annotation

CodeScene Delta Analysis / CodeScene Code Health Review (release/17.0)

❌ New issue: Excess Number of Function Arguments

Siblings has 5 arguments, max arguments = 4. This function has too many arguments, indicating a lack of encapsulation. Avoid adding more arguments.
=> await GetSiblings(target, before, after);
}
1 change: 1 addition & 0 deletions src/Umbraco.Core/Models/EntityContainer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ public sealed class EntityContainer : TreeEntityBase, IUmbracoEntity
{ Constants.ObjectTypes.DataType, Constants.ObjectTypes.DataTypeContainer },
{ Constants.ObjectTypes.DocumentType, Constants.ObjectTypes.DocumentTypeContainer },
{ Constants.ObjectTypes.MediaType, Constants.ObjectTypes.MediaTypeContainer },
{ Constants.ObjectTypes.MemberType, Constants.ObjectTypes.MemberTypeContainer },
{ Constants.ObjectTypes.DocumentBlueprint, Constants.ObjectTypes.DocumentBlueprintContainer },
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,11 @@ public EntityContainerRepository(
{
Guid[] allowedContainers =
{
Constants.ObjectTypes.DocumentTypeContainer, Constants.ObjectTypes.MediaTypeContainer,
Constants.ObjectTypes.DataTypeContainer, Constants.ObjectTypes.DocumentBlueprintContainer,
Constants.ObjectTypes.DataTypeContainer,
Constants.ObjectTypes.DocumentTypeContainer,
Constants.ObjectTypes.MediaTypeContainer,
Constants.ObjectTypes.MemberTypeContainer,
Constants.ObjectTypes.DocumentBlueprintContainer,
};
NodeObjectTypeId = containerObjectType;
if (allowedContainers.Contains(NodeObjectTypeId) == false)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,36 +1,26 @@
using Umbraco.Cms.Core.Models;
using Microsoft.Extensions.Logging;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Cache;
using Umbraco.Cms.Core.Persistence.Repositories;
using Umbraco.Cms.Infrastructure.Scoping;

namespace Umbraco.Cms.Infrastructure.Persistence.Repositories.Implement
namespace Umbraco.Cms.Infrastructure.Persistence.Repositories.Implement;

internal sealed class MemberTypeContainerRepository : EntityContainerRepository, IMemberTypeContainerRepository
{
/// <summary>
/// A no-op implementation of <see cref="IMemberTypeContainerRepository"/>, as containers aren't supported for members.
/// </summary>
/// <remarks>
/// Introduced to avoid inconsistencies with nullability of dependencies for type repositories for content, media and members.
/// </remarks>
internal sealed class MemberTypeContainerRepository : IMemberTypeContainerRepository
public MemberTypeContainerRepository(
IScopeAccessor scopeAccessor,
AppCaches cache,
ILogger<MemberTypeContainerRepository> logger,
IRepositoryCacheVersionService repositoryCacheVersionService,
ICacheSyncService cacheSyncService)
: base(
scopeAccessor,
cache,
logger,
Constants.ObjectTypes.MemberTypeContainer,
repositoryCacheVersionService,
cacheSyncService)
{
public void Delete(EntityContainer entity)
{
}

public bool Exists(int id) => false;

public EntityContainer? Get(Guid id) => null;

public IEnumerable<EntityContainer> Get(string name, int level) => Enumerable.Empty<EntityContainer>();

public bool HasDuplicateName(Guid parentKey, string name) => false;

public bool HasDuplicateName(int parentId, string name) => false;

public EntityContainer? Get(int id) => null;

public IEnumerable<EntityContainer> GetMany(params int[]? ids) => Enumerable.Empty<EntityContainer>();

public void Save(EntityContainer entity)
{
}
}
}