Skip to content

propertyValuePresentation extension type for displaying complex property values (fixes #20736) #20748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
+680 −309

Update src/Umbraco.Web.UI.Client/src/packages/documents/documents/col…

73c540c
Select commit
Loading
Failed to load commit list.
Open

propertyValuePresentation extension type for displaying complex property values (fixes #20736) #20748

Update src/Umbraco.Web.UI.Client/src/packages/documents/documents/col…
73c540c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (main) failed Nov 12, 2025 in 54s

CodeScene PR Check

Quality Gate Failed

Code Health Improved (3 files improve in Code Health)

Gates Failed
Enforce advisory code health rules (2 files with Complex Method)

Gates Passed
3 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Enforce advisory code health rules Violations Code Health Impact
document-collection-item-data-resolver.ts 1 advisory rule 9.47 Suppress
media-table-column-system-value.element.ts 1 advisory rule 9.69 Suppress
View Improvements
File Code Health Impact Categories Improved
document-table-column-property-value.element.ts 9.58 → 10.00 Complex Method
document-grid-collection-card.element.ts 9.50 → 10.00 Complex Method
media-table-collection-view.element.ts 9.69 → 10.00 Complex Method

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method document-collection-item-data-resolver.ts: UmbDocumentCollectionItemDataResolver.getSystemValue
  • Complex Method media-table-column-system-value.element.ts: UmbMediaTableColumnSystemValueElement.getPropertyValueByAlias

✅ Improving Code Health:

  • Complex Method document-grid-collection-card.element.ts: UmbDocumentGridCollectionCardElement.getPropertyValueByAlias
  • Complex Method document-table-column-property-value.element.ts: UmbDocumentTableColumnPropertyValueElement.getPropertyValueByAlias
  • Complex Method media-table-collection-view.element.ts: UmbMediaTableCollectionViewElement.getPropertyValueByAlias

Annotations

Check notice on line 36 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/table/column-layouts/document-table-column-property-value.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ No longer an issue: Complex Method 

UmbDocumentTableColumnPropertyValueElement.getPropertyValueByAlias is no longer above the threshold for cyclomatic complexity

Check notice on line 38 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/views/grid/document-grid-collection-card.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ No longer an issue: Complex Method 

UmbDocumentGridCollectionCardElement.getPropertyValueByAlias is no longer above the threshold for cyclomatic complexity

Check warning on line 36 in src/Umbraco.Web.UI.Client/src/packages/media/media/collection/views/table/column-layouts/media-table-column-system-value.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Method 

UmbMediaTableColumnSystemValueElement.getPropertyValueByAlias has a cyclomatic complexity of 11, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 159 in src/Umbraco.Web.UI.Client/src/packages/media/media/collection/views/table/media-table-collection-view.element.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

✅ No longer an issue: Complex Method 

UmbMediaTableCollectionViewElement.getPropertyValueByAlias is no longer above the threshold for cyclomatic complexity

Check warning on line 50 in src/Umbraco.Web.UI.Client/src/packages/documents/documents/collection/document-collection-item-data-resolver.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (main)

❌ New issue: Complex Method 

UmbDocumentCollectionItemDataResolver.getSystemValue has a cyclomatic complexity of 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis