Skip to content

TexBox: Data-type validation for max chars (fixes #18817) #20843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −1
Open

TexBox: Data-type validation for max chars (fixes #18817) #20843

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
381d611
configure max chars for textbox
nielslyngsoe Nov 14, 2025
4148f20
min 1
nielslyngsoe Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Umbraco.Web.UI.Client/src/packages/property-editors/text-box/Umbraco.TextBox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,12 @@ export const manifest: ManifestPropertyEditorSchema = {
{
alias: 'maxChars',
label: 'Maximum allowed characters',
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The description has been removed, but it would be helpful to update it rather than remove it completely. Consider adding a description similar to TextArea's approach. For example: "If empty, defaults to 512 characters" or "Maximum 512 characters allowed" to clarify the constraint being applied.

Suggested change
label: 'Maximum allowed characters',
label: 'Maximum allowed characters',
description: 'If empty, defaults to 512 characters.',

Copilot uses AI. Check for mistakes.
description: 'If empty, 512 character limit',
propertyEditorUiAlias: 'Umb.PropertyEditorUi.Integer',
config: [
{ alias: 'min', value: 1 },
Copy link

Copilot AI Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The minimum value is set to 1, which prevents users from setting maxChars to 0. However, the related TextArea property editor allows a minimum of 0 for its maxChars configuration (meaning unlimited). Consider whether TextBox should also allow 0 for consistency, or if there's a specific reason to enforce a minimum of 1 character.

Suggested change
{ alias: 'min', value: 1 },
{ alias: 'min', value: 0 },

Copilot uses AI. Check for mistakes.
{ alias: 'max', value: 512 },
{ alias: 'placeholder', value: '512' },
],
},
],
defaultData: [
Expand Down
Loading