Custom Domain for Microservice #365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamputraintan
added
the
metadata_manager
victorskl
approved these changes
Jun 24, 2024
| @@ -114,6 +115,7 @@ export class SequenceRunManagerStack extends Stack { | |||
| const srmApi = new ApiGatewayConstruct(this, 'ApiGateway', { | |||
| region: this.region, | |||
| apiName: 'SequenceRunManager', | |||
| customDomainNamePrefix: 'sequence-run', | |||
There was a problem hiding this comment.
In this case, could you change it to just sequence pls.
skel/django-api/deploy/stack.ts
Outdated
| @@ -117,6 +118,7 @@ export class ProjectNameStack extends Stack { // FIXME change construct name | |||
| const srmApi = new ApiGatewayConstruct(this, 'ApiGateway', { | |||
| region: this.region, | |||
| apiName: 'SequenceRunManager', | |||
| customDomainNamePrefix:'sequence-run', | |||
There was a problem hiding this comment.
Yup. Just sequence as noun pattern.
|
Updated! Will merge once test passed! |
williamputraintan
deleted the
feature(metadata-manager)/custom-domain-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadatafilesequence-runsequenceworkflowResolve #361