Skip to content

feat(turbpokack): normalize chunk path in runtime chunk registry #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

xusd320
Copy link

@xusd320 xusd320 commented May 30, 2025

Why

Fix a problem of that when

CHUNK_BASE_PATH = "./dist" 

and script tag add in HTML is

<script src="dist/chunk.js"></script>

The dist/chunk.js chunk will never being resolved after script loaded.

How

Just erasing out differences of ./ prefix and / suffix.

Can be upstreamed?

True

Copy link
Member

@fireairforce fireairforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个改动应该会附带 next.js 的测试更新?

@xusd320
Copy link
Author

xusd320 commented May 30, 2025

这个改动应该会附带 next.js 的测试更新?

测试更新会提到上游,我们跑不了 next.js 的 CI 流程,没法更新

@xusd320 xusd320 merged commit 138cc86 into utoo-patch-v15.3.2 May 30, 2025
11 of 21 checks passed
@xusd320 xusd320 deleted the feat/turboapack-runtime-chunk-path branch July 3, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants