feat: externalType support global #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireairforce
changed the title
xusd320
requested changes
May 28, 2025
turbopack/crates/turbopack-ecmascript-runtime/js/src/shared/runtime-types.d.ts
Outdated
Show resolved
Hide resolved
xusd320
requested changes
May 28, 2025
...pack/crates/turbopack-ecmascript-runtime/js/src/browser/runtime/edge/runtime-backend-edge.ts
Outdated
Show resolved
Hide resolved
fireairforce
force-pushed
the
fix-output-assets-extension
branch
from
4e96256 to
eee1b8f
Compare
fireairforce
force-pushed
the
fix-output-assets-extension
branch
from
eee1b8f to
6e0b78a
Compare
fireairforce
changed the title
xusd320
approved these changes
May 29, 2025
| CachedExternalType::Global => { | ||
| writeln!( | ||
| code, | ||
| // TODO: change after v15.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now turbopack's externalType only support the following types:
The type
CommonJsandEcmaScriptModuleonly support to userequire()orimport()to deal the external module(it's friendly to the NodeJS or Edege Runtime enviroment, seems not friendly to the browser enviroment), so meybe we can support the externalType like 'global'(https://webpack.js.org/configuration/externals/#externalstypeglobal) or other externalType like https://webpack.js.org/configuration/externals/#externalstypevar, which can help us to set the external module into a global var.