feat(turbopack): improve compile-time define value to support more data types and expr evaluation #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ine evaluate value
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
xusd320
changed the title
|
Upstream PR: vercel#81042 |
xusd320
force-pushed
the
feat/upstream-turboapack-define-env
branch
from
3486fc9 to
a57283a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Let compile-time define env supports full types of json and basical evaluation. See examples at
https://github.com/umijs/next.js/blob/feat/upstream-turboapack-define-env/turbopack/crates/turbopack-tests/tests/snapshot.rs#L261-L286
This may also improve the minification because more static informations being provided when handling define env. But this change may affect the ecmascript analysis and tree-shaking, so need a careful review.