Skip to content

feat(turbopack)): use chunk items ident's hash for grouped chunk ident #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

xusd320
Copy link

@xusd320 xusd320 commented May 29, 2025

What

The common_path has some problem, e.g:

| lazy/
|    index.ts

The content of lazy/index.ts:

import lodash from "lodash"
window._ = lodash;

the lazy/index.ts. and lodash are bundled into a same chunk. Because the lodash's path is in node_modules directory, out of lazy directory,so the common_path will be empty. So, we change the chunk path to be determined by chunk item ident path hash.

Can be upstreamed?

Yes

@xusd320 xusd320 merged commit 03a2d1a into utoo-patch-v15.3.2 May 29, 2025
9 of 19 checks passed
@xusd320
Copy link
Author

xusd320 commented May 29, 2025

Upstream PR: vercel#79918

@xusd320 xusd320 deleted the feat/grouped-chunk-ident branch May 29, 2025 15:07
xusd320 added a commit that referenced this pull request Jun 9, 2025
xusd320 added a commit that referenced this pull request Jun 9, 2025
* Revert "perf(turbopack): only use idents' hash when chunk is empty (#17)"

This reverts commit f53822d.

* Revert "feat(turbopack)): use chunk items ident's hash for grouped chunk ident (#8)"

This reverts commit 03a2d1a.

* fix(turbopack): fix browser chunk_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants