Skip to content

Conversation

@xiaohuoni
Copy link
Member

@xiaohuoni xiaohuoni commented Dec 20, 2024


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC. Support bundle with webpack #49
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests and other checks with pnpm ci

规则是用户自己安装 @umijs/bundler-webpack 触发 doctor 报错 @sorrycc

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features and fix bugs should all be patch before we release 0.1.0. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2024

🦋 Changeset detected

Latest commit: 6c455f8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sorrycc
Copy link
Member

sorrycc commented Dec 26, 2024

doctor 到问题不大,主要是少了 dev,之前也尝试加过,但发现 bundler-webpack 这个包接 dev 比较麻烦,于是就先放着了。

@xiaohuoni
Copy link
Member Author

我看需求里面写,只要实现 build 我以为,只要 build 阶段切换 webpack。
那我再跑一跑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants