feat:New sing in UI #589
Closed
feat:New sing in UI #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed all instances of "api" to "platform" in the apps/web
Created a procedure to separate the logic checking if the user in the organization is an administrator
Created a procedure to separate the logic checking if the user in the organization is an administrator
The login has been restructured according to design
Added the rest of the logic to handle the 2FA
|
Closed due to issues described in #592 |
BlankParticle
added a commit
that referenced
this pull request
Jul 23, 2024
## What does this PR do? This PR has the same changes from #589, that PRs history is not same with the history of our main branch. Upon trying to rebase this PR, I was getting 54 conflicts due to the folder rename. The old PR is based on main branch, so I cant force push either, thus this PR > From Old PR <img width="425" alt="Screenshot 2024-07-22 at 17 56 40" src="https://github.com/user-attachments/assets/31d9e67f-d74e-42ed-90a9-f30dbdeee984"> <img width="558" alt="Screenshot 2024-07-22 at 17 57 29" src="https://github.com/user-attachments/assets/4c90f884-3bba-46ab-98e4-d9ab5674d58d"> ## Type of change <!-- Please mark the relevant points by using [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Chore (refactoring code, technical debt, workflow improvements) - [ ] Enhancement (small improvements) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## Checklist <!-- We're starting to get more and more contributions. Please help us making this efficient for all of us and go through this checklist. Please tick off what you did --> ### Required - [ ] Read [Contributing Guide](https://github.com/un/inbox/blob/main/CONTRIBUTING.md) - [ ] Self-reviewed my own code - [ ] Tested my code in a local environment - [ ] Commented on my code in hard-to-understand areas - [ ] Checked for warnings, there are none - [ ] Removed all `console.logs` - [ ] Merged the latest changes from main onto my branch with `git pull origin main` - [ ] My changes don't cause any responsiveness issues ### Appreciated - [ ] If a UI change was made: Added a screen recording or screenshots to this PR - [ ] Updated the UnInbox Docs if changes were necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
New Login UI, also Buttons align center on new image upload
Fixes # (issue)
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
Checklist
Required
console.logsgit pull origin mainAppreciated