Skip to content

fix: add pointer cursor to participant panel trigger #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

OmarMcAdam
Copy link
Member

@OmarMcAdam OmarMcAdam commented Jul 23, 2024

TL;DR

Added the cursor-pointer class to a div element in the Participants component to enhance user interactivity.

What changed?

A div within the Participants component now includes the cursor-pointer class. This change makes the element more visibly interactive to users by changing the cursor to a pointer when hovered over.

How to test?

  1. Navigate to a conversation page that displays the participants list.
  2. Hover over the participants' names.
  3. Observe if the cursor changes to a pointer.

Why make this change?

The change improves the UI/UX by giving users a visual indication that the element is interactive, which aligns with standard web practices.


What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @McPizza0 and the rest of your teammates on Graphite Graphite

@OmarMcAdam OmarMcAdam marked this pull request as ready for review July 23, 2024 13:00
@OmarMcAdam OmarMcAdam changed the title fix-ENG-74 fix: add pointer cursor to participant panel trigger Jul 23, 2024
@OmarMcAdam OmarMcAdam merged commit 022a047 into main Jul 23, 2024
8 checks passed
Copy link
Member Author

Merge activity

  • Jul 23, 9:53 AM EDT: @McPizza0 merged this pull request with Graphite.

@BlankParticle BlankParticle deleted the fix-ENG-74 branch July 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants