Skip to content

omar/eng-87-signup-agree-to-terms-is-checked-by-default #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

OmarMcAdam
Copy link
Member

@OmarMcAdam OmarMcAdam commented Jul 24, 2024

TL;DR

The pull request updates the default state of the 'agree' variable in the user registration page from 'true' to 'false'.

What changed?

In the file apps/web/src/app/join/page.tsx, the initial state of the 'agree' useState hook has been changed from 'true' to 'false'.

How to test?

  1. Navigate to the user registration page.
  2. Check the default state of the user agreement checkbox.
  3. It should now be unchecked by default.

Why make this change?

This change ensures that users actively opt-in to the agreement rather than being opted in by default. This approach enhances user consent and aligns with best practices for user agreements and privacy policies.


What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @McPizza0 and the rest of your teammates on Graphite Graphite

@OmarMcAdam OmarMcAdam marked this pull request as ready for review July 24, 2024 15:49
@OmarMcAdam OmarMcAdam force-pushed the omar/eng-87-signup-agree-to-terms-is-checked-by-default branch from b0e08ba to 9be6ab7 Compare July 24, 2024 16:15
Copy link
Member Author

OmarMcAdam commented Jul 24, 2024

Merge activity

  • Jul 24, 12:16 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 24, 12:18 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 24, 12:19 PM EDT: @McPizza0 merged this pull request with Graphite.

@OmarMcAdam OmarMcAdam force-pushed the omar/eng-87-signup-agree-to-terms-is-checked-by-default branch from 9be6ab7 to 627b2db Compare July 24, 2024 16:17
@OmarMcAdam OmarMcAdam merged commit 95c4c12 into main Jul 24, 2024
5 checks passed
@BlankParticle BlankParticle deleted the omar/eng-87-signup-agree-to-terms-is-checked-by-default branch July 24, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants