Skip to content

fix(inviteUrl): remove unnecessary protocol from url #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

benjaminshafii
Copy link
Collaborator

@benjaminshafii benjaminshafii commented Jul 26, 2024

TL;DR

Ensure the inviteUrl no longer includes the protocol https://.

What changed?

Removed the https:// protocol prefix from the inviteUrl when generating a new invite link.

How to test?

  1. Generate a new invite link.
  2. Verify that the generated invite URL does not include the https:// prefix.

Why make this change?

This change ensures better flexibility when resolving URLs based on different contexts or environments, avoiding hard-coded protocols.


What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ashgansh and the rest of your teammates on Graphite Graphite

@benjaminshafii benjaminshafii marked this pull request as ready for review July 26, 2024 15:28
@benjaminshafii benjaminshafii changed the title remove unnecessary url fix(inviteUrl): remove unnecessary protocol from url Jul 26, 2024
@benjaminshafii benjaminshafii merged commit 36f4e6c into main Jul 26, 2024
7 checks passed
Copy link
Collaborator Author

Merge activity

  • Jul 26, 1:20 PM EDT: @ashgansh merged this pull request with Graphite.

BlankParticle pushed a commit that referenced this pull request Jul 27, 2024
@BlankParticle BlankParticle deleted the 07-26-remove_unnecessary_url branch July 28, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants