Skip to content

feat: UI optimizations for avatar, personal addresses and addNewAddresses modal #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Esther-Lita
Copy link
Collaborator

@Esther-Lita Esther-Lita commented Jul 29, 2024

  • Created a new ExternalEmailModal component for adding external email addresses to the organization
  • Updated AddEmailModal component to open the ExternalEmailModal when selecting 'Add External Email Instead'
  • Removed the obsolete external email page and transferred its functionalities to the new ExternalEmailModal component
  • Added state management for modals in the organization mail addresses page
    -Resizing avatar on account creation
    -Properly aligned personal addresses

fixes issues: ENG-51 ENG-69 ENG-47


What does this PR do?

Fixes # (issue)

If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Esther-Lita and the rest of your teammates on Graphite Graphite

@Esther-Lita Esther-Lita changed the title modal changes Show modal to add external email Jul 29, 2024
@Esther-Lita Esther-Lita changed the title Show modal to add external email feat: UI optimizations for avatar, personal addresses and add new addresses. Jul 29, 2024
@Esther-Lita Esther-Lita changed the title feat: UI optimizations for avatar, personal addresses and add new addresses. feat: UI optimizations for avatar, personal addresses and addNewAddresses modal Jul 29, 2024
@Esther-Lita Esther-Lita marked this pull request as ready for review July 29, 2024 18:24
Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also check CI and fix those errors

@BlankParticle BlankParticle merged commit fe3bd15 into main Jul 31, 2024
5 checks passed
@BlankParticle BlankParticle deleted the UI-little-fixes branch July 31, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants