-
Notifications
You must be signed in to change notification settings - Fork 123
feat: ability to reset password with recovery email #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apps/web/src/app/[orgShortcode]/settings/user/security/_components/RecoveryEmailSection.tsx
Show resolved
Hide resolved
BlankParticle
requested changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few simple things to change to keep consistentcy around the code base
BlankParticle
approved these changes
Jul 31, 2024
4abb41c
to
c8b68bf
Compare
@McPizza0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's an explanation of the changes in this PR using the provided template:
What does this PR do?
This PR implements a password recovery flow for the UnInbox application. It adds new routes and components for requesting a password reset, verifying the recovery code, and setting a new password. The PR also includes updates to the security settings page and the recovery email functionality.
Key changes include:
We opted for a code-only recovery token of length 6 (alphanumeric) for simplicity and ease of use. This approach allows users to easily enter the code on mobile devices or read it over the phone if necessary. However, we might extend this to include recovery links in the future based on user feedback and security considerations.
Fixes # (issue)
Type of change
Checklist
Required
console.logs
git pull origin main
Appreciated
If a UI change was made: Added a screen recording or screenshots to this PR
Updated the UnInbox Docs if changes were necessary
passwordrecoveryflow.mp4