Skip to content

feat: ability to reset password with recovery email #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 1, 2024
Merged

Conversation

benjaminshafii
Copy link
Collaborator

@benjaminshafii benjaminshafii commented Jul 30, 2024

Here's an explanation of the changes in this PR using the provided template:

What does this PR do?

This PR implements a password recovery flow for the UnInbox application. It adds new routes and components for requesting a password reset, verifying the recovery code, and setting a new password. The PR also includes updates to the security settings page and the recovery email functionality.

Key changes include:

  1. New recovery flow pages: request, verify, and reset password
  2. Updated recovery email section in the user security settings
  3. New API endpoints for sending recovery emails and resetting passwords
  4. Updated middleware to allow access to new recovery routes

We opted for a code-only recovery token of length 6 (alphanumeric) for simplicity and ease of use. This approach allows users to easily enter the code on mobile devices or read it over the phone if necessary. However, we might extend this to include recovery links in the future based on user feedback and security considerations.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Enhancement (small improvements)

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR

  • Updated the UnInbox Docs if changes were necessary

passwordrecoveryflow.mp4

@benjaminshafii benjaminshafii marked this pull request as ready for review July 30, 2024 14:31
Copy link
Member

@BlankParticle BlankParticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few simple things to change to keep consistentcy around the code base

@BlankParticle
Copy link
Member

@McPizza0
I think its ok to merge it, anything you want to add?

@OmarMcAdam OmarMcAdam merged commit 610c46e into main Aug 1, 2024
5 checks passed
@OmarMcAdam OmarMcAdam deleted the recovery-flow-3 branch August 1, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants