Skip to content

fix: inline images breaking due to special characters #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

BlankParticle
Copy link
Member

@BlankParticle BlankParticle commented Aug 28, 2024

What does this PR do?

Fixes ENG-166
Inline images now work even if they have special characters in their names

also fixed the bug where replying with attachments were sent marked as inline so users could not see them

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

Required

  • Read Contributing Guide
  • Self-reviewed my own code
  • Tested my code in a local environment
  • Commented on my code in hard-to-understand areas
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the UnInbox Docs if changes were necessary

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @BlankParticle and the rest of your teammates on Graphite Graphite

@BlankParticle BlankParticle requested a review from a team August 28, 2024 17:39
@BlankParticle BlankParticle added bug Something isn't working priority these issues needs to prioritize before others labels Aug 28, 2024 — with Graphite App
@BlankParticle BlankParticle marked this pull request as ready for review August 28, 2024 17:39
@BlankParticle BlankParticle merged commit c341627 into main Aug 28, 2024
8 checks passed
Copy link
Member Author

BlankParticle commented Aug 28, 2024

Merge activity

@BlankParticle BlankParticle deleted the blank/fix/inline-attachment-special-character-breaking branch August 28, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority these issues needs to prioritize before others
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants