feature: implement issuance workflow

[bla-ce]

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Description

This PR implements the VerifiableCredentialService to issue a credential using the interfaces that have been defined in #360.

Related Tickets & Documents

ref #353

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📖 Mock App docs site
• 📜 README.md
• 📕 storybook
• 🙅 no documentation needed

[gemini-code-assist]

Summary of Changes

Hello @bla-ce, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly advances the project by implementing the foundational workflow for issuing Verifiable Credentials. It defines clear interfaces for key services related to decentralized identity, such as credential issuance, identity resolution, and storage, thereby establishing a robust and extensible architecture. The changes are thoroughly tested to ensure the stability and correctness of the new credential issuance capabilities.

Highlights

• Verifiable Credential Issuance Workflow: Implemented the core VerifiableCredentialService to handle the issuance of Verifiable Credentials (VCs), including the logic for obtaining credential status and interacting with external APIs for signing.
• New Service Interfaces: Introduced new TypeScript interfaces (IVerifiableCredentialService, IIdentityResolverService, IStorageService) to define contracts for Verifiable Credential operations, identity resolution, and credential storage, enhancing modularity and extensibility.
• Comprehensive Unit Tests: Added extensive unit tests for the VerifiableCredentialService to ensure the reliability and correctness of the VC issuance process, covering various scenarios including default values, custom headers, and error handling.
• Utility Type Definitions: Included new utility types (JSONValue, Extensible, NonEmptyArray, OneOrMany) to improve type safety and clarity across the codebase, particularly for handling flexible data structures.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant feature by implementing the verifiable credential issuance workflow. The changes include a new VerifiableCredentialService, comprehensive unit tests, and several new interfaces for related services. My review has identified a critical bug in the credential construction logic that violates the W3C specification and could lead to incorrect behavior. Additionally, there's a critical issue in the tests where the mock data does not align with the defined types, which undermines the reliability of the test suite. I've also provided several medium-severity suggestions to improve code quality, such as avoiding parameter mutation, improving interface design by grouping parameters, and making tests more robust. Addressing these points will significantly improve the correctness and maintainability of the new issuance workflow.

[github-actions]

Code Coverage Report

Lines	Statements	Branches	Functions
	77.3% (3989/5160)	61.68% (1132/1835)	62.56% (483/772)

Title	Lines	Statements	Branches	Functions
All packages		77.3% (3989/5160)	61.68% (1132/1835)	62.56% (483/772)
Components		72.4% (740/1022)	56.25% (180/320)	49.62% (132/266)
Mock app		56.8% (405/713)	46.3% (238/514)	56.64% (81/143)
Services		79.01% (1103/1396)	64.34% (287/446)	74.83% (113/151)
UNTP test suite		85.75% (1090/1271)	81.35% (144/177)	67.21% (41/61)
VC test suite		100% (20/20)	100% (2/2)	100% (4/4)
UNTP Playground		86.01% (664/772)	74.86% (283/378)	76.82% (116/151)