Feature: implement storage workflow

[bla-ce]

What type of PR is this? (check all applicable)

• 🍕 Feature
• 🐛 Bug Fix
• 📝 Documentation Update
• 🎨 Style
• 🧑‍💻 Code Refactor
• 🔥 Performance Improvements
• ✅ Test
• 🤖 Build
• 🔁 CI
• 📦 Chore (Release)
• ⏩ Revert

Description

This PR implements the StorageService to register signed credentials using the interfaces that have been defined in #360

Related Tickets & Documents

#354

Added tests?

• 👍 yes
• 🙅 no, because they aren't needed
• 🙋 no, because I need help

Added to documentation?

• 📖 Mock App docs site
• 📜 README.md
• 📕 storybook
• 🙅 no documentation needed

[gemini-code-assist]

Summary of Changes

Hello @bla-ce, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new StorageService to manage the registration and storage of signed verifiable credentials. It establishes a standardized and robust workflow for interacting with external storage APIs, ensuring data integrity and proper error management while abstracting the underlying HTTP communication details.

Highlights

• New StorageService Implementation: Introduced a new StorageService class responsible for storing signed verifiable credentials to a specified API endpoint.
• Flexible Storage Methods: The store method supports both 'POST' and 'PUT' HTTP methods, allowing flexibility in how credentials are sent to the storage service.
• Robust Input Validation and Error Handling: Implemented validation for required parameters like URL and bucket name, along with comprehensive error handling for network requests and unexpected exceptions during the storage process.
• Comprehensive Unit Tests: A dedicated test file (storageService.test.ts) has been added, covering various scenarios including successful storage, custom headers, parameter validation, and different error conditions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a StorageService for storing verifiable credentials, along with a comprehensive set of unit tests. The overall implementation is well-structured. My review has identified a significant issue regarding how HTTP headers are passed to the underlying httpService, which would prevent custom headers from being applied. I've also noted that logging errors to the console in a library function can be an undesirable side effect. I have provided suggestions to fix the header issue and update the corresponding tests, as well as a recommendation to remove the console logging.

[github-actions]

Code Coverage Report

Lines	Statements	Branches	Functions
	77.2% (3950/5116)	61.72% (1121/1816)	62.36% (479/768)

Title	Lines	Statements	Branches	Functions
All packages		77.2% (3950/5116)	61.72% (1121/1816)	62.36% (479/768)
Components		72.4% (740/1022)	56.25% (180/320)	49.62% (132/266)
Mock app		56.8% (405/713)	46.3% (238/514)	56.64% (81/143)
Services		78.69% (1064/1352)	64.63% (276/427)	74.14% (109/147)
UNTP test suite		85.75% (1090/1271)	81.35% (144/177)	67.21% (41/61)
VC test suite		100% (20/20)	100% (2/2)	100% (4/4)
UNTP Playground		86.01% (664/772)	74.86% (283/378)	76.82% (116/151)