Introducing EventDateTime #143
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be a first step as an example to dividing the CalendarDateTime class for interoperability and reusability, to align with SS4 principles. Introducing new super class EventDateTime . See unclecheese/silverstripe-event-calendar issue 140. Time & date specific fields ($db properties) and reusable functionality tied to those properties moved to EventDateTime. ie CalendarDateTime methods with reference to Event() remain. Have included a reversible migration task to assist with moving table fields to the new intermediary tier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a first step as an example to dividing the CalendarDateTime class for interoperability and reusability, to align with SS4 principles.
Introducing new super class EventDateTime . See unclecheese/silverstripe-event-calendar issue 140.
Time & date specific fields ($db properties) and reusable functionality tied to those properties moved to EventDateTime. ie CalendarDateTime methods with reference to Event() or that are relevant to CalendarAnnouncement remain.
Have included a reversible migration task to assist with moving table fields to the new intermediary tier.