Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how pydantic models load configurations to comply with pydantic 2 #679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

banagale
Copy link

@banagale banagale commented Feb 14, 2025

Summary

Fixes #678

  • Updates method of setting pydantic model configuration to 2.0 standard.

List of files changed and why

crawl4ai.models.py - Had two models using old style of pydantic configuration

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added/updated unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@banagale
Copy link
Author

I'm seeing "Merge is not an allowed merge method in this repository." on the new and improved merge experience here. Switching to classic, it seems fine.

If this merge is blocked due to something on my end, please lmk.

@banagale banagale force-pushed the feature/678/update-pydantic-model-config branch from 2dfa5a7 to f4f6b57 Compare March 18, 2025 21:11
@banagale
Copy link
Author

This is a fairly minor fix, so I have not written tests. Please let me know if there are additional changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Deprecation Warning: Replace Config with ConfigDict for Pydantic v2 Compatibility
1 participant