fixed arun_many for AsyncHTTPCrawlerStrategy when url list contains m… #821
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #794
List of files changed and why
async_crawler_strategy.py - removed the http client session context manager (only used in _handle_http method) which caused the problem when trying to crawl more than one url with more than one session allowed from the dispatcher (max_session_permit attribute). The problem occured when the context manager closed the session after completing a given task and another task was using this session to do its http request. The http client session lifecycle is already managed by the web crawler using its context manager or using explicit lifecycle management.
How Has This Been Tested?
Unit tests have been added in a new file 'test_http_crawler.py' to test:
Checklist: