Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meteor update to 1.8.1 and new multistage Dockerfile #750

Closed
wants to merge 4 commits into from

Conversation

kaihendry
Copy link
Contributor

meteor-dockerfilegen -port 3000 > Dockerfile

meteor-dockerfilegen -port 3000 > Dockerfile
Kai Hendry added 3 commits April 9, 2019 15:28
…modules/meteor-node-stubs/readable-stream@git+https:/github.com/meteor/readable-stream.git#2e9112d7d31a2af6e0682db0e18679b1e5fd4694" as it does not contain a package.json file.
@kaihendry
Copy link
Contributor Author

I had some issues with installing postcss-easy-import as you can see in the build history with meteor npm i hence the additional npm i. I'm also suspicious of the package lock, hence the removal.

Now it appears to work. Be good to test this in staging.

@kaihendry kaihendry requested a review from nbiton April 10, 2019 02:20
@franck-boullier
Copy link
Member

@nbiton is it OK to merge this?

kaihendry pushed a commit that referenced this pull request Feb 7, 2020
#750 which I think solves
#892 (comment)
because it locks down to .meteor/release
@kaihendry
Copy link
Contributor Author

Not sure why this wasn't merged. It's now quite out of date. Closing in favour of #894

@kaihendry kaihendry closed this Feb 7, 2020
kaihendry pushed a commit that referenced this pull request Feb 10, 2020
#750 which I think solves
#892 (comment)
because it locks down to .meteor/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants