Skip to content

Conversation

@Nifury
Copy link
Member

@Nifury Nifury commented Dec 1, 2025

Update the CI pipeline so that:

  1. It first creates a release draft.
  2. Artifacts are uploaded to the draft as soon as they are generated.
  3. Mark the release as ready once all artifacts have been created.

It should work based on my mock test: https://github.com/Nifury/test-artifact/actions/runs/19835202594

Fixes #517 (comment).

P.S.
I just realized the simplest fix might be to increase the retention period instead...

@teeminus
Copy link
Contributor

teeminus commented Dec 1, 2025

What's the most robust way to fix our issue? This PR or increasing the retention period?

@Nifury
Copy link
Member Author

Nifury commented Dec 2, 2025

I'm leaning slightly towards this PR.
Besides, I don't have access to change the retention period setting.

@teeminus
Copy link
Contributor

teeminus commented Dec 2, 2025

Do we have to manually clean up pre-releases when a pipeline fails?

@PF4Public
Copy link

Besides, I don't have access to change the retention period setting.

Is it a repo setting?

@Nifury
Copy link
Member Author

Nifury commented Dec 2, 2025

Do we have to manually clean up pre-releases when a pipeline fails?

I pushed a commit to fix this.

Is it a repo setting?

Nope, it is set in the code..(by me...)

'C:\\ungoogled-chromium-windows\\build', {retentionDays: 1, compressionLevel: 0});

How about I close this PR and just adjust the retention period instead? That seems simpler, and the original logic is already well-tested.

@teeminus
Copy link
Contributor

teeminus commented Dec 3, 2025

I think this PR is more elegant as it publishes the files once they are available. However, if adjusting the retention period fixes the problem as well I am fine with that as well.

If adjusting the retention period does not fix the issue we can still use this PR.

@teeminus
Copy link
Contributor

teeminus commented Dec 4, 2025

I increased the retention time for the next release: #520

If that does not fix the pipeline I tend to merge this.

@dixianapp

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants