Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17803 site: improve top nav #4022

Closed
wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Sep 5, 2024

CLDR-17803

image

image

  • improve look of top nav.

  • don't list a page twice in subpages

  • show entire breadcrumb

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295
Copy link
Member Author

srl295 commented Sep 5, 2024

So, if someone creates a PR in their own fork, it CANNOT create a preview site. Something to be aware of.

Closing in favor of #4023

@srl295 srl295 closed this Sep 5, 2024
Copy link
Contributor

@AEApple AEApple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it takes up less space when there are so many subpages

@srl295
Copy link
Member Author

srl295 commented Sep 5, 2024

I like that it takes up less space when there are so many subpages

thanks but check out #4023 you can try it yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants