Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18006 site: fix h-levels #4108

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 4, 2024

  • also, run prettier on html and css
  • merge reports-v2.css into page.css
  • add prettier to package.json so it can be launched with 'npm run pretty'

originally filed at CLDR-17947

CLDR-18006

Testing notes:

I don't have a test page checked in but see for example the CLDR 46 release page

Example test:

image

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

- also, run prettier on html and css
- merge reports-v2.css into page.css
- add prettier to package.json so it can be launched with 'npm run pretty'

supports items from CLDR-17947
@srl295 srl295 requested a review from macchiati October 4, 2024 17:03
@srl295 srl295 self-assigned this Oct 4, 2024
Copy link

github-actions bot commented Oct 4, 2024

✨ deployed to https://eeb97159.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Oct 4, 2024
@srl295 srl295 requested a review from AEApple October 4, 2024 19:30
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in file name and reformatting make this hard to review, but the results look good.

@srl295 srl295 merged commit ce677ad into main Oct 4, 2024
15 checks passed
@srl295 srl295 deleted the srl295/site/cldr-18006/further-css branch October 4, 2024 22:14
@srl295
Copy link
Member Author

srl295 commented Oct 4, 2024

yes, but the formatting should keep it stable in the future.

srl295 added a commit to srl295/cldr that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants