Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-18072 Clean up links in CLDR site #4171

Merged
merged 3 commits into from
Nov 4, 2024
Merged

CLDR-18072 Clean up links in CLDR site #4171

merged 3 commits into from
Nov 4, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Oct 31, 2024

-Fix links in seven files, per spreadsheet; rows in spreadsheet have been struck through

-Mark this file as OBSOLETE: design-proposals/xmb.md; keep the reference to it from docs/site/sitemap.tsv

CLDR-18072

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Fix links in seven files, per spreadsheet; rows in spreadsheet have been struck through

-Remove one obsolete file: design-proposals/xmb.md
@github-actions github-actions bot added the Site Update Updates docs/site label Oct 31, 2024
Copy link

✨ deployed to https://1afe31e5.cldr.pages.dev

@btangmu btangmu marked this pull request as ready for review October 31, 2024 19:53
@macchiati
Copy link
Member

Unless there is a strong reason not to, we want to keep old links working.

The easiest way to do that is

  • in the sitemap, just move the file to the last under the archive section (above the sitemap)
  • in the file in question, add OBSOLETE in the title and first

cf:
@AEApple

Copy link

github-actions bot commented Nov 1, 2024

✨ deployed to https://76740f7c.cldr.pages.dev

@btangmu
Copy link
Member Author

btangmu commented Nov 1, 2024

keep old links working

OK, I've restored xmb.md, adding "OBSOLETE", and I've restored its link from sitemap.tsv

@AEApple
Copy link
Contributor

AEApple commented Nov 2, 2024

Longer term can we consider changing the theme of obsolete pages to further differentiate them?

@macchiati
Copy link
Member

macchiati commented Nov 3, 2024 via email

@srl295
Copy link
Member

srl295 commented Nov 3, 2024

Longer term can we consider changing the theme of obsolete pages to further differentiate them?

Yes. That would be adding a new layout obsolete and then

layout: obsolete in the front matter (where the title is)

@btangmu btangmu merged commit a1961cc into main Nov 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants