Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start of the Englishes #4190

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Start of the Englishes #4190

wants to merge 3 commits into from

Conversation

AEApple
Copy link
Contributor

@AEApple AEApple commented Nov 11, 2024 •
edited
Loading

CLDR-_____ TBD

It looks like the African metazones are present in most locales

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

markusicu
markusicu reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you are splitting African English out of World English?
Not sure that I have an opinion here.

Do the individual locale files no longer have/need a parent locale entry?

common/main/en_GH.xml
</currencies>
</numbers>
</ldml>
</ldml>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the line ending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu left review comments

@macchiati macchiati Awaiting requested review from macchiati

@richgillam richgillam Awaiting requested review from richgillam

At least 1 approving review is required to merge this pull request.

Assignees

@AEApple AEApple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AEApple @markusicu