Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-15972 Improve Catalan RBNF #4196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

grhoten
Copy link
Member

@grhoten grhoten commented Nov 12, 2024

CLDR-15972

There are multiple fixes for the larger numbers for Catalan. These changes also include the addition of the plural ordinal rules for both masculine and feminine, and fix roundtrip parsing of digit ordinals.

These changes were tested with the Number Format Tester.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@markusicu
Copy link
Member

I don't feel competent reviewing RBNF changes. Added @richgillam as a reviewer...

@grhoten
Copy link
Member Author

grhoten commented Nov 13, 2024

I'm actually queueing up several pull requests for RBNF this week. I plan on asking someone to review these pull requests once these are in good shape. It's tedious to ask for CLDR-TC approval and a reviewer separately for each issue and pull request. It would be easier to do it all in bulk. Some of these fixes are 1 line changes. Though if someone wants to preemptively assign each issue to me and approve the pull requests, that's fine too.

All changes have been verified to parse and roundtrip with Number Format Tester, and that the new observed behavior matches the desired requested change.

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak to the actual linguistic content, but the changes look plausible and syntactically everything looks fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants