CLDR-14829 Wrong ordinal and year spellout in French#5449
Open
grhoten wants to merge 1 commit intounicode-org:mainfrom
Open
CLDR-14829 Wrong ordinal and year spellout in French#5449grhoten wants to merge 1 commit intounicode-org:mainfrom
grhoten wants to merge 1 commit intounicode-org:mainfrom
Conversation
grhoten
commented
Mar 10, 2026
| 2000: =%spellout-numbering=; | ||
| 1100/100: <%spellout-cardinal-masculine<-cent[ >>|s]; | ||
| 2000: <%%spellout-leading< mil[ >>]; | ||
| 10000: =%spellout-numbering=; |
Member
Author
There was a problem hiding this comment.
This fixes an issue in multi-issue CLDR ticket 9907.
2016 should be deux mil seize.
| 80/20: quatre-vingt[->>|s]; | ||
| 100: cent[ >>]; | ||
| 200: << cent>%%cents-m>; | ||
| 200: << cent[ >>|s]; |
Member
Author
There was a problem hiding this comment.
Modernize the syntax so that it's easier to read.
| 1000000: <%%spellout-leading< $(cardinal,one{million}other{millions})$[ >>]; | ||
| 1000000000: <%%spellout-leading< $(cardinal,one{milliard}other{milliards})$[ >>]; | ||
| 1000000000000: <%%spellout-leading< $(cardinal,one{billion}other{billions})$[ >>]; | ||
| 1000000000000000: <%%spellout-leading< $(cardinal,one{billiard}other{billiards})$[ >>]; |
Member
Author
There was a problem hiding this comment.
Modernize the syntax so that it's easier to read.
Comment on lines
+123
to
+128
| 20: vingt[->%%et-unieme>|ième]; | ||
| 30: trent[e->%%et-unieme>|ième]; | ||
| 40: quarant[e->%%et-unieme>|ième]; | ||
| 50: cinquant[e->%%et-unieme>|ième]; | ||
| 60/20: soixant[e->%%et-unieme>|ième]; | ||
| 80/20: quatre-vingt[->>|ième]; |
Member
Author
There was a problem hiding this comment.
This modernizes the syntax for easier reading.
Member
There was a problem hiding this comment.
Question: where is the more modern syntax defined?
| 1000000: <%%spellout-leading< [$(cardinal,one{million}other{millions})$ >>|millionième]; | ||
| 1000000000: <%%spellout-leading< [$(cardinal,one{milliard}other{milliards})$ >>|milliardième]; | ||
| 1000000000000: <%%spellout-leading< [$(cardinal,one{billion}other{billions})$ >>|billionième]; | ||
| 1000000000000000: <%%spellout-leading< [$(cardinal,one{billiard}other{billiards})$ >>|billiardième]; |
Member
Author
There was a problem hiding this comment.
There were several issues here.
- 101e should be
cent unième. It shouldn't have theet. - The correct plural was never chosen due to the lack of the or-else pipe operator in the brackets. Now that it's available, we can correct it.
Contributor
|
@eggrobin - Do you want to review this since you drove the most recent plural updates for French? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLDR-14829
ALLOW_MANY_COMMITS=true