Add logging configuration (#127)

.gitignore

@@ -30,3 +30,5 @@ testdriver/.local-chrome/
 testgen/*.json
 
 TEMP_DATA/*
+
+debug.log*

logging.conf

@@ -0,0 +1,33 @@
+[loggers]
+keys=root
+
+[logger_root]
+handlers=screen,file
+level=NOTSET
+
+[formatters]
+keys=simple,complex
+
+[formatter_simple]
+format=[%(asctime)s] [%(levelname)s]  %(message)s
+
+[formatter_complex]
+format=[%(asctime)s,%(module)s:%(lineno)d] [%(levelname)s]  %(message)s
+
+[handlers]
+keys=file,screen
+
+[handler_file]
+class=handlers.TimedRotatingFileHandler
+interval=midnight
+backupCount=5
+formatter=complex
+level=DEBUG
+# equivalent to:  'debug.log', when='S', interval=10, backupCount=5
+args=('debug.log', 'S', 10, 5)
+
+[handler_screen]
+class=StreamHandler
+formatter=simple
+level=INFO
+args=(sys.stdout,)

schema/check_generated_data.py

@@ -7,6 +7,7 @@
 
 
 import logging
+import logging.config
 import os.path
 import sys
 
@@ -16,6 +17,8 @@
 from schema_files import ALL_TEST_TYPES
 
 def main(args):
+    logging.config.fileConfig("../logging.conf")
+
     if len(args) <= 1:
         logging.error('Please specify the path to test data directory')
         return

schema/check_schemas.py

@@ -7,6 +7,7 @@
 
 
 import logging
+import logging.config
 import os.path
 import sys
 
@@ -16,6 +17,7 @@
 class ValidateSchema():
     def __init__(self, schema_base='.'):
         self.schema_base = schema_base
+        logging.config.fileConfig("../logging.conf")
 
     def save_schema_validation_summary(self, validation_status):
 

schema/check_test_output.py

@@ -8,6 +8,7 @@
 
 
 import logging
+import logging.config
 import os.path
 import sys
 
@@ -17,6 +18,8 @@
 from schema_files import ALL_TEST_TYPES
 
 def main(args):
+    logging.config.fileConfig("../logging.conf")
+
     if len(args) <= 1:
         logging.error('Please specify the path to the test output directory')
         exit(1)

schema/schema_validator.py

@@ -10,6 +10,7 @@
 from jsonschema import exceptions
 
 import logging
+import logging.config
 import os.path
 import sys
 
@@ -33,6 +34,8 @@ def __init__(self):
         self.icu_versions = []
         self.debug_leve = 0
 
+        logging.config.fileConfig("../logging.conf")
+
     def validate_json_file(self, schema_file_path, data_file_path):
         # Returns  True, None if data is validated against the schema
         # returns  Falee, error_string if there's a problem
@@ -139,7 +142,7 @@ def check_test_data_schema(self, icu_version, test_type):
             test_result = result
         results['result'] = result
         if result:
-            logging.info('Test data %s validated with %s, ICU %s', test_type, icu_version)
+            logging.info('Test data %s validated successfully, with ICU %s', test_type, icu_version)
         else:
             logging.error('Test data %s FAILED with ICU %s: %s', test_type, icu_version, err_info)
 

testdriver/testdriver.py

@@ -5,6 +5,7 @@
 from datetime import datetime
 import json
 import logging
+import logging.config
 import os
 import subprocess
 import sys
@@ -24,6 +25,9 @@ def __init__(self):
         self.icuVersion = None
         self.test_plans = []
         self.debug = False
+
+        logging.config.fileConfig("../logging.conf")
+
         return
 
     def set_args(self, arg_options):

testdriver/testplan.py

@@ -2,6 +2,7 @@
 import glob
 import json
 import logging
+import logging.config
 import os
 import subprocess
 import sys
@@ -53,6 +54,8 @@ def __init__(self, exec_data, test_type, args=None):
 
         self.verifier = None
 
+        logging.config.fileConfig("../logging.conf")
+
     def set_options(self, options):
         self.options = options
         try:

testgen/testdata_gen.py

@@ -3,6 +3,7 @@
 import argparse
 import json
 import logging
+import logging.config
 import math
 import os
 import re
@@ -26,6 +27,8 @@ def __init__(self, icu_version):
         # If set, this is the maximum number of tests generated for each.
         self.run_limit = None
 
+        logging.config.fileConfig("../logging.conf")
+
     def setVersion(self, selected_version):
         self.icu_version = selected_version
 

verifier/report_template.py

@@ -2,11 +2,14 @@
 import glob
 import json
 import logging
+import logging.config
 from string import Template
 import sys
 
 class reportTemplate():
     def __init__(self):
+        logging.config.fileConfig("../logging.conf")
+
         # Read the template data
         detail_template = ''
         filename = 'detail_template.html'

verifier/testreport.py

@@ -13,6 +13,7 @@
 import glob
 import json
 import logging
+import logging.config
 import os
 from string import Template
 import sys
@@ -46,6 +47,8 @@ def __init__(self):
 
         self.params_diff = {}
 
+        logging.config.fileConfig("../logging.conf")
+
     def add_diff(self, num_diffs, diff_list, last_diff):
         # Record single character differences
         if num_diffs == 1:
@@ -127,6 +130,8 @@ def __init__(self, report_path, report_html_path):
 
         self.test_unsupported_template = templates.test_unsupported_template
 
+        logging.config.fileConfig("../logging.conf")
+
     def set_title(self, executor, result_version, test_type):
         self.title = 'Test %s executed on %s with data %s' % (test_type, executor, result_version)
 
@@ -863,6 +868,8 @@ def __init__(self, file_base):
             '<td>$report_detail</td>'
         )
 
+        logging.config.fileConfig("../logging.conf")
+
     def get_json_files(self):
         # For each executor directory in testReports,
         #  Get each json report file

verifier/verifier.py

@@ -4,6 +4,7 @@
 import glob
 import json
 import logging
+import logging.config
 import os
 import shutil
 import sys
@@ -62,6 +63,8 @@ def __init__(self):
         # Filename used for the json version of verifier output
         self.report_filename = VERIFIER_REPORT_NAME
 
+        logging.config.fileConfig("../logging.conf")
+
     def open_verify_files(self):
         # Get test data, verify data, and results for a case.
         try: