Skip to content

Commit

Permalink
Remove configs from off-the-shelf GH Actions for clang-tidy / C++ lin…
Browse files Browse the repository at this point in the history
…ting
  • Loading branch information
echeran committed Nov 12, 2024
1 parent a8a3559 commit 776f789
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/clang-tidy-review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,26 +29,3 @@ jobs:
run: |
pushd executors/cpp
clang-tidy *.cpp --config-file="clang-tidy-config.yml" -p .
# Optionally generate compile_commands.json

# Run clang-tidy
# Note: when running locally at the command line, use the equivalent
# command when in the directory `executors/cpp`:
# clang-tidy *.cpp --fix-errors --config-file="clang-tidy-config.yml" -p .
# Note: you must run setup.sh and also run install_icu4c_binary.sh (for a given ICU4C version) first
# before running the above clang-tidy command
- uses: cpp-linter/cpp-linter-action@v2
with:
repo-root: "./executors/cpp"
style: 'file' # Use .clang-format config file
tidy-checks: '' # Use .clang-tidy config file
# not enough permissions in default GITHUB_TOKEN to post on public fork PRs
# thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
# extra-args: '--config-file="clang-tidy-config.yml" -p=.'
id: linter
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
# If there are any comments, fail the check
- if: steps.linter.outputs.checks-failed > 0
run: exit 1

0 comments on commit 776f789

Please sign in to comment.