Fsync for file output #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add plural rules to CPP * Starting ICU4X datetime fmt * DateTime format: Set default timezone explicitly * Fix formatting * Added ICU4X timezone computation - not working yet! * DateTime generator updated to ISO formatted string * DateTime updates for Node and ICU4C. * Formatted src/datetimefmt.rs * Updated using CustomTimeZone in ICU4X date time fmt * Cargo clippified * Remove unused function * Update version to ~1.3
|
This is an easy one! |
echeran
reviewed
Sep 19, 2024
| @@ -91,6 +91,7 @@ def main(args): | |||
| output_filename = os.path.join(test_data_path, 'test_data_validation_summary.json') | |||
| file_out = open(output_filename, mode='w', encoding='utf-8') | |||
| file_out.write(summary_data) | |||
| os.fsync(file_out) | |||
There was a problem hiding this comment.
Here and below: follow instructions for os.fsync() to include the appropriate argument and additionally do os.flush() prior to the fsync, since you are getting a file object from os.open().
|
Abandoning this PR because it's not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make sure that the output is synchronized with parallel execution.