Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dart #87

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Fix dart #87

merged 3 commits into from
Aug 10, 2023

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Aug 10, 2023

  • Add version string of the intl4x dependency by parsing the pubspec.lock file
  • Add locale to avoid having dart_web looking for the users locale in the window object, which doesn't exist in NodeJS.

sven-oly
sven-oly approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@sven-oly sven-oly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates.

@sven-oly sven-oly merged commit f096121 into unicode-org:main Aug 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sven-oly sven-oly sven-oly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosuem @sven-oly