Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22531 Remove X from XLikelySubtags* #2662

Merged

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Oct 5, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22531
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang
Copy link
Contributor Author

I think we should wait till 75, right?

@markusicu markusicu self-assigned this Oct 12, 2023
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/loclikely.cpp is different
  • icu4c/source/common/loclikelysubtags.cpp is different
  • icu4j/main/core/src/main/java/com/ibm/icu/util/ULocale.java is different
  • icu4j/main/core/src/test/java/com/ibm/icu/dev/test/util/LocaleMatcherTest.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

@markusicu friendly ping

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/loclikelysubtags.cpp is different
  • icu4j/main/core/src/main/java/com/ibm/icu/impl/locale/LikelySubtags.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor Author

@roubert @richgillam and @mihnita this is a very simple PR. I hope you can help to offload @markusicu time to help review it. All it does is to remove the X per what markus put on the bug report. Nothing more complicate than that.

Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@FrankYFTang FrankYFTang merged commit 8d3d214 into unicode-org:main Nov 17, 2023
100 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22531-rename-LikelySubtags branch November 17, 2023 22:49
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you


I don't know why, but on this PR all I get is "Submit review"
I hope that is enough.
It's weird, because I usually get "Comment", "Approve" and "Request changes"
(I just approved PR 2700, and I had those 3 options)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants