-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22531 Remove X from XLikelySubtags* #2662
ICU-22531 Remove X from XLikelySubtags* #2662
Conversation
I think we should wait till 75, right? |
38029ba
to
f771c99
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@markusicu friendly ping |
f771c99
to
71d0c78
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
@roubert @richgillam and @mihnita this is a very simple PR. I hope you can help to offload @markusicu time to help review it. All it does is to remove the X per what markus put on the bug report. Nothing more complicate than that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you
I don't know why, but on this PR all I get is "Submit review"
I hope that is enough.
It's weird, because I usually get "Comment", "Approve" and "Request changes"
(I just approved PR 2700, and I had those 3 options)
Checklist