ICU-22513 Return error if days is too large in IslamicUmalquraCalendar #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankYFTang
force-pushed
the
ICU-22513-calendar-slow
branch
from
75afd68
to
1f81c58
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
If the year is too large it may overflow the int32_t variable and cause slow or infinity loop, return error if the year is too large that the conversion to day may overflow int32_t. Limit the value to max value of int32_t divide by 400.
FrankYFTang
force-pushed
the
ICU-22513-calendar-slow
branch
from
1f81c58
to
0c8a874
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
richgillam
approved these changes
Oct 26, 2023
| cal.clear(); | ||
| cal.add(Calendar.YEAR, 1229080905); | ||
| cal.roll(Calendar.WEEK_OF_MONTH, 1499050699); | ||
| cal.fieldDifference(new Date(0), Calendar.YEAR_WOY); |
There was a problem hiding this comment.
Maybe I'm missing something, but shouldn't there be some kind of "expect exception to be thrown" logic in this test?
There was a problem hiding this comment.
Java use long (64 bits) for those value so it will not throw exception with that setting. The test just make sure it will not be infinity loop or time out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The computation in IslamicUmalquraCalendar is slower than others, if the days is more than 10,000 years from the epoch, we just return error to avoid hang.
Checklist