Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22326 BRS: Version number update for GA #2683

Merged
merged 1 commit into from
Oct 26, 2023
Merged

ICU-22326 BRS: Version number update for GA #2683

merged 1 commit into from
Oct 26, 2023

Conversation

jalaj-microsoft
Copy link
Contributor

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22326
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@markusicu markusicu self-requested a review October 26, 2023 16:08
yumaoka
yumaoka previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@yumaoka yumaoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We probably should manage version in one place after 74.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/depstest/dependencies.txt is now changed in the branch
  • icu4c/source/test/fuzzer/locale_util.h is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran merged commit 97e2f3b into unicode-org:maint/maint-74 Oct 26, 2023
99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echeran echeran echeran approved these changes

@yumaoka yumaoka yumaoka left review comments

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@yumaoka yumaoka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jalaj-microsoft @echeran @yumaoka @jalaj-h