Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Composition with Resolved Value sections for default functions #927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eemeli
Copy link
Collaborator

@eemeli eemeli commented Nov 7, 2024

As we've now defined resolved value as a term, and e.g. formatting refers to "resolving" placeholders, we should replace/expand the "Composition" sections of default function descriptions with "Resolved Value" sections.

This should help provide a clearer basis for the text around :number offset proposed in #926, which is currently proposing two alternative resolved value definitions for :number.

Copy link
Member

@aphillips aphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aphillips
Copy link
Member

aphillips commented Nov 7, 2024

The :date and :time sections make me itch a bit. I want to say more than just "implementation-defined type" but don't really want to reawaken the "sleeping bear" of an issue about whether (or not) the type "trims" the other part of the value (e.g. :date removes time units or :time removes y-m-d units)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants