Fix/update uppercase
custom function example per latest messageformat@next
#46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context: MessageFunctionContext
, notlocales: string[]
)toString
doesn't work withformat
orformatToParts
toLocaleUpperCase
with the locales available in the context, rather than locale-lesstoUpperCase
It seems like building on top of the built-in
DefaultFunctions.string
is the simplest way to implement a customstring -> string
function that correctly implements the contract expected byformat
andformatToParts
. The returned object for input"{messageformat :uppercase}"
looks roughly like this: