-
-
Notifications
You must be signed in to change notification settings - Fork 24
chore: bump all non-breaking dev deps #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- package.json: Language not supported
Comments suppressed due to low confidence (2)
readme.md:614
- Verify that changing the code block language from 'txt' to 'console' correctly renders the expected output in all environments; if the output differs from expectations, consider using a different language identifier.
```console
readme.md:1658
- Confirm that the removal of these duplicate link references does not break any documentation links that may be used elsewhere.
-[node-readable-stream]: https://nodejs.org/api/stream.html#readable-streams
Please split in different PRs. Dev-deps are fine in this PR. Actual deps are breaking changes. Please use |
Now, only dev deps change.
I misunderstood |
@wooorm And also, as I mentioned, |
Signed-off-by: JounQin <[email protected]>
This comment has been minimized.
This comment has been minimized.
Many are When you merge PRs, please follow the existing commit style: Also, please apply labels. The bot helps you with this. In this case, I will add |
Closes GH-78. Reviewed-by: Remco Haszing <[email protected]> Reviewed-by: Christian Murphy <[email protected]>
@wooorm Could there be a tool for checking this on (I'll wait for you to merge PRs after then |
Maybe, but, as you know, I don’t think there needs to be a tool for everything 😉 I’d much rather teach you the style, that you can then merge PRs yourself! I would like for you to merge PRs! Take a look at the commits there (or in other repos, such as mdx-js/mdx).
The most common commits are |
Thanks! I'll learn to do that correctly. |
Initial checklist
Description of changes
As title