Dataplane Ingress reasonable defaults #161
Open
+45
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: We are converging on a world where the Dataplane and Controlplane will be designed to run their own respective ingress. This adds a natural separate of concern and allows maximum configurability between the two services. * Update dataplane values.yaml with Union specific controller defaults * Don't always assume the `Values.host` is the ingress host. This allows to not couple the two. Leaving Ingress host empty is now feasible and less coupling. This also supports a world that allows dataplane to interact with controlplane intra-cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We are converging on a world where the Dataplane and
Controlplane will be designed to run their own respective ingress.
This adds a natural separate of concern and allows maximum
configurability between the two services.
Values.hostis the ingress host. This allowsto not couple the two. Leaving Ingress host empty is now feasible and
less coupling. This also supports a world that allows dataplane to
interact with controlplane intra-cluster.