Support configuring image repository and tags through helm-charts #173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
mhotan
force-pushed
the
mike/simplify-configuring-image-repositories
branch
from
515eb1c to
e6f38d2
Compare
pmahindrakar-oss
approved these changes
Nov 4, 2025
Comment on lines
+639
to
+660
| flytescheduler: | ||
| image: | ||
| # TODO flyte-core does not render templated repository and tag correctly. | ||
| # PR: https://github.com/flyteorg/flyte/pull/6711 | ||
| repository: "643379628101.dkr.ecr.us-east-1.amazonaws.com/union-cp/flytescheduler" | ||
| pullPolicy: IfNotPresent | ||
| tag: "" |
Contributor
There was a problem hiding this comment.
We have turned this service off by default so we dont need this. Check L648
Contributor
Author
There was a problem hiding this comment.
We should probably leave it here in the event we have to re-enable it.
mhotan
force-pushed
the
mike/simplify-configuring-image-repositories
branch
2 times, most recently
from
d84da5f to
c51d3ab
Compare
Signed-off-by: Michael Hotan <[email protected]>
mhotan
force-pushed
the
mike/simplify-configuring-image-repositories
branch
from
c51d3ab to
bfb09e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it simpler to configure image repositories and tags. controlplane flyte subchart use of global settings depends on flyteorg/flyte#6711. Conforms to internal Union release process.
Control plane version bump