Skip to content

Fix XSS on 404 page #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix XSS on 404 page #530

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f083bf2
Fix XSS on 404 page
bdconnolly Oct 13, 2025
5f1991d
Merge branch 'main' into brian/fix-more-xss
bdconnolly Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions themes/union/layouts/_default/four-o-four.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,43 @@
{{- $variantFullName := index .Site.Params.Key.product_full_name $variant -}}
{{- $extraContent := readFile (printf "404.inc.html~%s" $variant) -}}
<script>
function sanitizeText(text) {
if (!text) return '';
// Create a temporary element to escape HTML
const temp = document.createElement('div');
temp.textContent = text;
return temp.innerHTML;
}

function validateVariant(variant) {
// Only allow alphanumeric characters and hyphens
return variant && /^[a-zA-Z0-9-]+$/.test(variant) ? variant : null;
}

// Extract query string parameters
let url = new URL(window.location);
const source = url.searchParams.get('source');
const pVariant = url.searchParams.get('variant');
const origin = url.searchParams.get('origin');
const targetVariant = url.searchParams.get('targetVariant');
const targetHomeUrl = '/docs/' + targetVariant;
// const source = url.searchParams.get('source');
// const pVariant = url.searchParams.get('variant');
// const origin = url.searchParams.get('origin');
// const targetVariant = url.searchParams.get('targetVariant');
// const targetHomeUrl = '/docs/' + targetVariant;
const source = sanitizeText(url.searchParams.get('source'));
const pVariant = validateVariant(url.searchParams.get('variant'));
const origin = sanitizeText(url.searchParams.get('origin'));
const targetVariant = validateVariant(url.searchParams.get('targetVariant'));
const targetHomeUrl = targetVariant ? `/docs/${encodeURIComponent(targetVariant)}` : '/docs/';

document.addEventListener('DOMContentLoaded', function() {
if (pVariant !== null) {
if (pVariant !== null && targetVariant !== null) {
const title = document.getElementById('title');
title.innerHTML = source;
title.textContent = source;

const buttonContainer = document.getElementById('button-container');

const button = document.createElement('sl-button');
console.log(button);
button.href = targetHomeUrl;
button.innerHTML = `
button.textContent = `
Go to ${targetVariant.toLocaleUpperCase()} home
`;
buttonContainer.appendChild(button);
Expand Down