Skip to content

mobile header #4841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Jul 17, 2025
Merged

mobile header #4841

merged 24 commits into from
Jul 17, 2025

Conversation

Swepool
Copy link
Contributor

@Swepool Swepool commented Jul 15, 2025 •
edited
Loading

  • the big change here is double header for mobile
  • navigation is now its own component we reuse in desktop sidebar and mobile menu
  • no more js for showing/hiding sidebar and adjusting main width, just tailwind breakpoints.
  • redirect is now on load with 302

@Swepool Swepool requested review from cor, benluelo and ehegnes as code owners July 15, 2025 23:50
@vercel Vercel
Copy link

vercel bot commented Jul 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
site ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 4:57pm

@Swepool Swepool marked this pull request as draft July 15, 2025 23:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

App 2 🤌

✨ Deployment complete! Take a peek over at https://31d7c712.app2-9yo.pages.dev
✨ Deployment alias URL: https://head.app2-9yo.pages.dev

@Swepool Swepool marked this pull request as ready for review July 16, 2025 11:41
ehegnes
ehegnes previously approved these changes Jul 17, 2025
View reviewed changes
@Swepool Swepool merged commit 3cac4fb into main Jul 17, 2025
121 checks passed
@Swepool Swepool deleted the header branch July 17, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehegnes ehegnes ehegnes approved these changes

@cor cor Awaiting requested review from cor cor is a code owner

@benluelo benluelo Awaiting requested review from benluelo benluelo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swepool @ehegnes