feat(cosmwasm): introduce escrow vault for fungibility layer #4937
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hussein-aitlahcen
force-pushed
the
cosmwasm-fungible-layer
branch
from
3e80ab3 to
9237d5f
Compare
hussein-aitlahcen
force-pushed
the
cosmwasm-fungible-layer
branch
from
9237d5f to
b0723cc
Compare
PoisonPhang
approved these changes
Aug 5, 2025
benluelo
reviewed
Aug 7, 2025
| let fee = order | ||
| .base_amount | ||
| .checked_sub(order.quote_amount) | ||
| .expect("impossible"); |
There was a problem hiding this comment.
perhaps I'm missing some context but why is this impossible?
There was a problem hiding this comment.
we check that base covers quote in term of amount just before
There was a problem hiding this comment.
ah ok i missed that line. maybe good to do the comparison as the checked_sub call then? then we can match on the result, instead of doing the check twice?
| value.as_bytes().into() | ||
| } | ||
|
|
||
| fn decode_value(raw: &Bytes) -> StdResult<Addr> { |
There was a problem hiding this comment.
Todo for me: add a default addr value codec impl somehow in depolama
| type Encoding = Bincode; | ||
| } | ||
|
|
||
| pub type BaseToken = Bytes; |
There was a problem hiding this comment.
either newtype wrapped or don't use an alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A CosmWasm contract that acts as a solver in the zkgm protocol, enabling fungible token transfers across IBC channels by managing escrowed assets.
Key Features
How It Works
Security