Update TokenBucket.t.sol #4955
Open
Update TokenBucket.t.sol #4955
+33
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add input validation and safety checks to TokenBucket testing contract - Added `require(token != address(0))` to prevent misuse of null token address. - Enforced `require(capacity > 0)` and `require(refillRate > 0)` in `setConfig()` to align test assumptions with production safety. - Added new test cases for invalid token input. - Ensures input validation is reflected both in tests and simulated logic. Note: This is a proposed improvement by a novice contributor for learning and safety enhancement purposes.
|
@serkanmax is attempting to deploy a commit to the unionbuild Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add input validation and safety checks to TokenBucket testing contract
require(token != address(0))to prevent misuse of null token address.require(capacity > 0)andrequire(refillRate > 0)insetConfig()to align test assumptions with production safety.Note: This is a proposed improvement by a novice contributor for learning and safety enhancement purposes.