Remove duplicate taxa #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve the duplicate taxa when reporting all taxa.
There was a problem hiding this comment.
Pull request overview
This PR adds deduplication of taxa before calculating the Lowest Common Ancestor (LCA) and when reporting all taxa in the pept2data endpoint. The change ensures that duplicate taxon IDs from multiple proteins are removed, which should improve both the accuracy of LCA calculations and the clarity of reported results.
Key Changes:
- Added
itertools::Itertoolsimport to enable theunique()method - Applied
.unique()to the taxa iterator before collecting into a vector, removing duplicate taxon IDs while preserving the order of first occurrences
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pverscha
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove duplicate taxa before calculating the LCA. This will also remove the duplicate taxa when reporting all taxa.